-
Notifications
You must be signed in to change notification settings - Fork 24
test that sparse tibbles work in fit()
#245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know you didn't request review, but these changes look good to me once you feel they're ready! Going to focus in on the redundant conversions now.
Co-authored-by: Simon P. Couch <simonpatrickcouch@gmail.com>
double checked and these error are only tailor related. Merging to get going |
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Ref: #239