Skip to content

Conversation

EmilHvitfeldt
Copy link
Member

@EmilHvitfeldt EmilHvitfeldt commented Oct 14, 2022

This PR adds modelenv to allow us to work with tidyclust model specifications without direct dependency since modelenv handles all the mode registration.

This PR should not be merged until:

  • modelenv gets on CRAN
  • DESCRIPTION file gets updated with minimal version of modelenv AND remove modelenv from Remotes

Merge commit '789d803b0d9cc0b7a515b349f733139cb2caebed'

Conflicts:
	DESCRIPTION
@EmilHvitfeldt EmilHvitfeldt marked this pull request as ready for review October 19, 2022 00:14
@simonpcouch
Copy link
Contributor

Awesome, thank you! Super excited that this is set up.

@simonpcouch simonpcouch merged commit fbf5738 into main Oct 24, 2022
@simonpcouch simonpcouch deleted the modelenv branch October 24, 2022 12:06
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants