-
Notifications
You must be signed in to change notification settings - Fork 116
move methods for tune_args()
from tune to here
#830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,189 @@ | ||
|
||
# Lazily registered in .onLoad() | ||
tune_args_recipe <- function(object, full = FALSE, ...) { | ||
|
||
steps <- object$steps | ||
|
||
if (length(steps) == 0L) { | ||
return(tune_tbl()) | ||
} | ||
|
||
res <- purrr::map_dfr(object$steps, tune_args, full = full) | ||
tune_tbl( | ||
res$name, | ||
res$tunable, | ||
res$id, | ||
res$source, | ||
res$component, | ||
res$component_id, | ||
full = full | ||
) | ||
} | ||
|
||
# @export - lazily and conditionally registered in .onLoad() | ||
tune_args_step <- function(object, full = FALSE, ...) { | ||
|
||
step_id <- object$id | ||
# Grab the step class before the subset, as that removes the class | ||
step_type <- class(object)[1] | ||
|
||
tune_param_list <- tunable(object)$name | ||
|
||
# remove the non-tunable arguments as they are not important | ||
object <- object[tune_param_list] | ||
|
||
# Remove NULL argument steps. These are reserved | ||
# for deprecated args or those set at prep() time. | ||
object <- object[!purrr::map_lgl(object, is.null)] | ||
|
||
res <- purrr::map_chr(object, find_tune_id) | ||
res <- ifelse(res == "", names(res), res) | ||
|
||
tune_tbl( | ||
name = names(res), | ||
tunable = unname(!is.na(res)), | ||
id = unname(res), | ||
source = "recipe", | ||
component = step_type, | ||
component_id = step_id, | ||
full = full | ||
) | ||
} | ||
|
||
|
||
# @export - lazily and conditionally registered in .onLoad() | ||
tune_args_check <- tune_args_step | ||
|
||
|
||
# helpers for tune_args() methods ----------------------------------------- | ||
# they also exist in parsnip for the `tune_args()` method there | ||
|
||
# useful for standardization and for creating a 0 row tunable tbl | ||
# (i.e. for when there are no steps in a recipe) | ||
tune_tbl <- function(name = character(), | ||
tunable = logical(), | ||
id = character(), | ||
source = character(), | ||
component = character(), | ||
component_id = character(), | ||
full = FALSE) { | ||
|
||
|
||
complete_id <- id[!is.na(id)] | ||
dups <- duplicated(complete_id) | ||
if (any(dups)) { | ||
stop("There are duplicate `id` values listed in [tune()]: ", | ||
paste0("'", unique(complete_id[dups]), "'", collapse = ", "), | ||
".", sep = "", call. = FALSE) | ||
} | ||
|
||
vry_tbl <- tibble::tibble( | ||
name = as.character(name), | ||
tunable = as.logical(tunable), | ||
id = as.character(id), | ||
source = as.character(source), | ||
component = as.character(component), | ||
component_id = as.character(component_id) | ||
) | ||
|
||
if (!full) { | ||
vry_tbl <- vry_tbl[vry_tbl$tunable,] | ||
} | ||
|
||
vry_tbl | ||
} | ||
|
||
# Return the `id` arg in tune(); if not specified, then returns "" or if not | ||
# a tunable arg then returns NA_character_ | ||
tune_id <- function(x) { | ||
if (is.null(x)) { | ||
return(NA_character_) | ||
} else { | ||
if (rlang::is_quosures(x)) { | ||
# Try to evaluate to catch things in the global envir. | ||
.x <- try(purrr::map(x, rlang::eval_tidy), silent = TRUE) | ||
if (inherits(.x, "try-error")) { | ||
x <- purrr::map(x, rlang::quo_get_expr) | ||
} else { | ||
x <- .x | ||
} | ||
if (is.null(x)) { | ||
return(NA_character_) | ||
} | ||
} | ||
|
||
# [tune()] will always return a call object | ||
if (is.call(x)) { | ||
if (rlang::call_name(x) == "tune") { | ||
# If an id was specified: | ||
if (length(x) > 1) { | ||
return(x[[2]]) | ||
} else { | ||
# no id | ||
return("") | ||
} | ||
return(x$id) | ||
} else { | ||
return(NA_character_) | ||
} | ||
} | ||
} | ||
NA_character_ | ||
} | ||
|
||
find_tune_id <- function(x) { | ||
|
||
# STEP 1 - Early exits | ||
|
||
# Early exit for empty elements (like list()) | ||
if (length(x) == 0L) { | ||
return(NA_character_) | ||
} | ||
|
||
# turn quosures into expressions before continuing | ||
if (rlang::is_quosures(x)) { | ||
# Try to evaluate to catch things in the global envir. If it is a dplyr | ||
# selector, it will fail to evaluate. | ||
.x <- try(purrr::map(x, rlang::eval_tidy), silent = TRUE) | ||
if (inherits(.x, "try-error")) { | ||
x <- purrr::map(x, rlang::quo_get_expr) | ||
} else { | ||
x <- .x | ||
} | ||
} | ||
|
||
id <- tune_id(x) | ||
if (!is.na(id)) { | ||
return(id) | ||
} | ||
|
||
if (is.atomic(x) | is.name(x) | length(x) == 1) { | ||
return(NA_character_) | ||
} | ||
|
||
# STEP 2 - Recursion | ||
|
||
# tunable_elems <- purrr::map_lgl(x, find_tune) | ||
tunable_elems <- vector("character", length = length(x)) | ||
|
||
# use purrr::map_lgl | ||
for (i in seq_along(x)) { | ||
tunable_elems[i] <- find_tune_id(x[[i]]) | ||
} | ||
|
||
tunable_elems <- tunable_elems[!is.na(tunable_elems)] | ||
if (length(tunable_elems) == 0) { | ||
tunable_elems <- NA_character_ | ||
} | ||
|
||
if (sum(tunable_elems == "", na.rm = TRUE) > 1) { | ||
stop( | ||
"Only one tunable value is currently allowed per argument. ", | ||
"The current argument has: `", | ||
paste0(deparse(x), collapse = ""), | ||
"`.", | ||
call. = FALSE) | ||
} | ||
|
||
return(tunable_elems) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
# nocov start | ||
|
||
.onLoad <- function(libname, pkgname) { | ||
|
||
# - If tune isn't installed, register the method (`packageVersion()` will error here) | ||
# - If tune >= 0.1.6.9001 is installed, register the method | ||
should_register_tune_args_method <- tryCatch( | ||
expr = utils::packageVersion("tune") >= "0.1.6.9001", | ||
error = function(cnd) TRUE | ||
) | ||
|
||
if (should_register_tune_args_method) { | ||
# `tune_args.recipe()` and friends moved from tune to recipes | ||
vctrs::s3_register("generics::tune_args", "recipe", tune_args_recipe) | ||
vctrs::s3_register("generics::tune_args", "step", tune_args_step) | ||
vctrs::s3_register("generics::tune_args", "check", tune_args_check) | ||
} | ||
} | ||
|
||
# nocov end |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.