Skip to content

remove tune_check() test helper #1088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2023
Merged

remove tune_check() test helper #1088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions tests/testthat/helpers.R
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions tests/testthat/test-extract.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@

test_that("extract parameter set from recipe with no steps", {
skip_if(tune_check())
bare_rec <- recipe(mpg ~ ., data = mtcars)

bare_info <- extract_parameter_set_dials(bare_rec)
Expand All @@ -9,7 +8,6 @@ test_that("extract parameter set from recipe with no steps", {
})

test_that("extract parameter set from recipe with no tunable parameters", {
skip_if(tune_check())
rm_rec <-
recipe(mpg ~ ., data = mtcars) %>%
step_rm(hp)
Expand All @@ -20,7 +18,6 @@ test_that("extract parameter set from recipe with no tunable parameters", {
})

test_that("extract parameter set from recipe with tunable parameters", {
skip_if(tune_check())
spline_rec <-
recipe(mpg ~ ., data = mtcars) %>%
step_impute_knn(all_numeric_predictors(), neighbors = hardhat::tune("imputation")) %>%
Expand Down Expand Up @@ -52,7 +49,6 @@ test_that("extract parameter set from recipe with tunable parameters", {
# -------------------------------------------------------------------------

test_that("extract single parameter from recipe with no steps", {
skip_if(tune_check())
bare_rec <- recipe(mpg ~ ., data = mtcars)

expect_snapshot(error = TRUE,
Expand All @@ -61,7 +57,6 @@ test_that("extract single parameter from recipe with no steps", {
})

test_that("extract single parameter from recipe with no tunable parameters", {
skip_if(tune_check())
rm_rec <-
recipe(mpg ~ ., data = mtcars) %>%
step_rm(hp)
Expand All @@ -72,7 +67,6 @@ test_that("extract single parameter from recipe with no tunable parameters", {
})

test_that("extract single parameter from recipe with tunable parameters", {
skip_if(tune_check())
spline_rec <-
recipe(mpg ~ ., data = mtcars) %>%
step_impute_knn(all_numeric_predictors(), neighbors = hardhat::tune("imputation")) %>%
Expand Down