create helper for newdata error

[simonpcouch]

Closes #525.

[EmilHvitfeldt]

Love it!

Is there a specific reason why you put the check in all the multi_predict.*() functions instead of in multi_predict() itself?

https://github.com/tidymodels/parsnip/blob/main/R/aaa_multi_predict.R#L20-L26

[simonpcouch]

I did so just to mirror exactly the existing implementation. We do do this check in the predict.model_fit() method, though, via check_pred_type_dots(), so maybe we should do the same in multi_predict()? I'm up for it if you are.

[EmilHvitfeldt]

I'm up!

[simonpcouch]

Worth mentioning that packages that re-export the multi_predict() generic will now receive this check as well, and this is probably worth revdepchecking and dropping in NEWS. Some other packages use a (now-)redundant check:

• bonsai @ https://github.com/tidymodels/bonsai/blob/aab79d511f1ae1d320da6a59335e8ed1f3e50be6/R/lightgbm.R#L354-L356
• rules @ https://github.com/tidymodels/rules/blob/1b27a2f229e7ab355eb3b837e264f655abbbc568/R/cubist_rules.R#L191-L193
• poissonreg @ https://github.com/tidymodels/poissonreg/blob/2ca5869df31db3bee845ac353201e1bc1b1bc78b/R/poisson_reg-glmnet.R#L29-L31
• rules @ https://github.com/tidymodels/rules/blob/1b27a2f229e7ab355eb3b837e264f655abbbc568/R/rule_fit.R#L196-L198
• censored @ https://github.com/tidymodels/censored/blob/f8d2dc1eb15893a8f3c29aa5770035d5be71e22a/R/proportional_hazards-glmnet.R#L252-L253

I do think dropping this into the generic is best for cutting down on technical debt in the long run, but will require a bit more effort. @hfrick, how do you feel about this change? While we're dropping this into a helper, would you make any revisions to the wording of the error?

[hfrick]

I think the generic is a good place for this check to live in 👍 +1 also to revdeps and NEWS item

[simonpcouch]

Wasn't expecting this, but:

We checked 59 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.

 * We saw 0 new problems

😮🎉

[github-actions]

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.