Simplify glmnet formatting helpers #882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
revdeps are also fine ✅ |
simonpcouch
approved these changes
Feb 22, 2023
There was a problem hiding this comment.
Loooving the +/- ratio here!🤩
Thanks for the thorough description. I'm on board, and this looks clean! Since these were changes we felt were worth revdepchecking for, perhaps we ought to include a note in NEWS.md? Will have to wait for a merge upstream after 1.0.4 is on CRAN to make those changes, though.
|
Good call! I'll wait until |
topepo
approved these changes
Feb 23, 2023
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #876
I didn't see any failures locally in the glmnet-related tests in extratests nor in the glmnet-related tests in censored and poissonreg which use the exported
.organize_glmnet_pred().