Skip to content

Re-registration of model information #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 23, 2022
Merged

Re-registration of model information #664

merged 8 commits into from
Feb 23, 2022

Conversation

topepo
Copy link
Member

@topepo topepo commented Feb 20, 2022

Closes #653

Models components (e.g. fit, pred, etc) can now be re-registered as long as the information is the same.

One caveat: package dependencies cannot be check for the same values since those are set one value at a time.

Copy link
Member

@hfrick hfrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no problems with censored or baguette - so nice to be able to use test() again 😀

topepo and others added 2 commits February 22, 2022 14:43
Co-authored-by: Davis Vaughan <davis@rstudio.com>
Co-authored-by: Hannah Frick <hfrick@users.noreply.github.com>
@topepo topepo merged commit f8310e5 into main Feb 23, 2022
@topepo topepo deleted the re-registration branch February 23, 2022 00:56
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow re-registration of same model information
3 participants