-
Notifications
You must be signed in to change notification settings - Fork 92
Add defaults to engine specific params in model docs #321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@juliasilge I believe this also would close #235? 🎉 |
For now I'm only adding these to the tables in the docs, with functions that are only run during Users could look at the docs and get the values but we haven't moved quite all the way to a dynamic lookup. |
We're going to have to make a call on what to do with the For ranger's
For ranger's
Neither of these are available via For randomForest, the function argument themselves are defined as: mtry=if (!is.null(y) && !is.factor(y))
max(floor(ncol(x)/3), 1) else floor(sqrt(ncol(x)))
nodesize = if (!is.null(y) && !is.factor(y)) 5 else 1 I think I'm going to put some of these in manually. |
Yes. I would add them as expressions to your data structure. Maybe something like "1C|5R|3S" with a legend on the bottom? |
The issues around |
I updated the |
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
This PR closes #211.
What I have so far here is my initial idea of how to add the default values for each engine specific parameter into the tables in the docs. These values are only needed for
devtools::document()
so I am thinking let's make little internal functions viapaste0()
rather thanget_model_env()
and add all these values via someset_...
function and keep them around.What are your thoughts?
Current results for the one model implemented right now:
Created on 2020-05-27 by the reprex package (v0.3.0)