Skip to content

Standardized output types for multi_predict and predict in multinom_reg #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 1, 2019

Conversation

patr1ckm
Copy link
Contributor

Fixes #222 .

@codecov-io
Copy link

codecov-io commented Oct 30, 2019

Codecov Report

Merging #226 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #226   +/-   ##
=======================================
  Coverage   76.32%   76.32%           
=======================================
  Files          38       38           
  Lines        2995     2995           
=======================================
  Hits         2286     2286           
  Misses        709      709
Impacted Files Coverage Δ
R/multinom_reg.R 79.09% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae66258...ef56340. Read the comment docs.

@topepo
Copy link
Member

topepo commented Nov 1, 2019

In multinom_reg.R, please add the levels to the factor call. If we only predict a single level, the factor levels won't be correct.

@topepo
Copy link
Member

topepo commented Nov 1, 2019

Thanks for these PRs. We are about to do a release so the timing is perfect.

@topepo topepo merged commit 976567f into tidymodels:master Nov 1, 2019
@github-actions
Copy link

github-actions bot commented Mar 7, 2021

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multimon_reg has different types of predictions
3 participants