Skip to content

Timing stopped at messages when engine fit fails #1109

Closed
@simonpcouch

Description

@simonpcouch

Intentionally introducing a failure:

# with extract_fit_time():
# pak::pak("tidymodels/parsnip@fd5124c")

library(parsnip)
library(modeldata)
  
boost_tree(mtry = tune::tune()) %>%
  set_mode("regression") %>%
  fit(bill_length_mm ~ ., data = penguins)
#> Error in min(denom, x): invalid 'type' (language) of argument
#> Timing stopped at: 0.002 0.001 0.003

Created on 2024-04-09 with reprex v2.1.0

Before #853:

# with CRAN:
library(parsnip)
library(modeldata)


boost_tree(mtry = tune::tune()) %>%
  set_mode("regression") %>%
  fit(bill_length_mm ~ ., data = penguins)
#> Error in min(denom, x): invalid 'type' (language) of argument

Created on 2024-04-09 with reprex v2.1.0

This showed up in snaps on bonsai.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugan unexpected problem or unintended behavior

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions