Skip to content

glmnet multi_predict(): tighten tests for checks on prediction type #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 15, 2023
Merged

glmnet multi_predict(): tighten tests for checks on prediction type #81

merged 4 commits into from
Mar 15, 2023

Conversation

hfrick
Copy link
Member

@hfrick hfrick commented Mar 2, 2023

hfrick
hfrick commented Mar 6, 2023
View reviewed changes
@hfrick hfrick requested a review from simonpcouch March 6, 2023 17:30
simonpcouch
simonpcouch approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woooo! I'm all for it.

Very satisfying to see the FIXMEs disappear!😆

@hfrick hfrick merged commit 49ea01e into main Mar 15, 2023
@hfrick hfrick deleted the glmnet-multi_predict-type-check branch March 15, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpcouch simonpcouch simonpcouch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hfrick @simonpcouch