Skip to content

unit tests for censoring probabilities #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 2, 2023
Merged

unit tests for censoring probabilities #67

merged 6 commits into from
May 2, 2023

Conversation

topepo
Copy link
Member

@topepo topepo commented Jan 20, 2023

For changes in tidymodels/parsnip#855

Depends on the most recent dev version of parsnip (1.0.3.9001)

@topepo
Copy link
Member Author

topepo commented Jan 20, 2023

Will merge when tidymodels/parsnip#855 is merged

@topepo topepo mentioned this pull request Jan 20, 2023
Merged
hfrick
hfrick reviewed Jan 25, 2023
View reviewed changes
Copy link
Member

@hfrick hfrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is obviously not in its final form while we iterate over the PRs on parsnip and censored but I spotted these little testthat alternatives 💁‍♀️

@hfrick hfrick marked this pull request as ready for review May 2, 2023 20:14
@hfrick hfrick merged commit 23811ff into main May 2, 2023
@hfrick hfrick deleted the cens-probs branch May 2, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfrick hfrick hfrick left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@topepo @hfrick