test messaging about missing extensions #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a model type with implementations in parsnip and several extension packages
`decision_tree` has engines in parsnip, censored, and bonsai, and modes in censored that aren't in parsnip! also, the message now won't note an engine if it wasn't specified by the user.
|
Companion PR to tidymodels/parsnip#793! This should be ready to merge. |
topepo
requested changes
Oct 6, 2022
other tests load the censored and baguette libraries, doing away with the prompt to load those extensions in snapshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linked PR fixes bugs related to how loading one unrelated extension would affect the messages related to another. This PR adds tests to extratests so we can load baguette and censored and see how that affects messages.
Won't be run until the parsnip release following the upcoming one is on CRAN, since I'm assuming this won't make it into the upcoming release.