Skip to content

add bagged neural networks #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 26, 2022
Merged

add bagged neural networks #64

merged 8 commits into from
Sep 26, 2022

Conversation

topepo
Copy link
Member

@topepo topepo commented Sep 22, 2022

Will require a parsnip release that adds bag_mlp(). See tidymodels/parsnip#815

@topepo topepo marked this pull request as ready for review September 22, 2022 15:49
Copy link
Member

@EmilHvitfeldt EmilHvitfeldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. I don't like the if (FALSE) { part inside the function, I assume it is some leftover manual testing that should be removed or incorporated into a unit test

@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants