-
Notifications
You must be signed in to change notification settings - Fork 8
add bagged neural networks #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. I don't like the if (FALSE) {
part inside the function, I assume it is some leftover manual testing that should be removed or incorporated into a unit test
Co-authored-by: Emil Hvitfeldt <emilhhvitfeldt@gmail.com>
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Will require a parsnip release that adds
bag_mlp()
. See tidymodels/parsnip#815