fix: Where clause is being ignored #796
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WHERE clause was being ignored for cross detection events in geofence/SETHOOK commands. This happened because testObject() (which checks WHERE clauses) was only called when an object was spatially inside the fence. For cross events, both old and new object positions are outside the fence, so testObject() was never invoked. This fix adds an explicit WHERE clause check (via fieldMatch) in the cross detection path before proceeding with event emission. This ensures that cross events are only triggered for objects that match the WHERE clause conditions. Fixes tidwall#795 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: majiayu000 <1835304752@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #795
Changes
testObject()was never called, so WHERE clause filtering was skipped for cross events