Add support for CORS in http requests #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kilowhisky
commented
May 6, 2024
| if _, err = wr.Write([]byte(corshead)); err != nil { | ||
| return false, err | ||
| } | ||
| return false, nil |
There was a problem hiding this comment.
This seems to work if I return false or true. Not sure which is correct.
|
Tests added |
|
Verified against my test project in chrome. Request works successfully. 
|
|
I'm cool with this. 🎸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not open a pull request without first filing an issue and/or discussing the feature directly with the project maintainer.
Please ensure you adhere to every item in this list
Describe your changes
Adds support for OPTIONS HTTP request and returns necessary headers to allow CORS to function properly
Issue number and link
#737
I'm not quite sure how testing should be performed here as I don't see any testing of the http interface right now.. maybe i'm missing something. Could use a pointer on where and how you'd like me to write tests.
Tests can be done with standard HTTP requests.