[BUG] Fix AWS SQS base domain parsing for China region #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For AWS China region base domain is slightly different than for the rest world. It is `amazon.com.cn`. Currently AWS domain is hard coded in the `sqs.go`. Would be nice if that will be configured parameter. But this is a minimal posible change which is not breaking exist code and make possible to use it for AWS China region.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure you adhere to every item in this list
Describe your changes
For AWS China region base domain is slightly different than for the rest world. It is
amazon.com.cn.Currently AWS domain is hard coded in the
sqs.go. Would be nice if that will be configured parameter.But this is a minimal possible change which is not breaking exist code and make possible to use it for AWS China region.