Enables cross platform building and pushing of docker images #682
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would fix #628.
I've tried to keep as close as possible to the current workflow.
I added the
make package
step to have the builds for the various platform ready. I removed the line that deletes the build folders from the package script so that those artefacts can be reused by the docker build.Finally building and pushing the docker containers is moved in a single step as the containers must be pushed directly by the buildx build.
I hope this will work in one go. I already tested the build but moved it out of the
if
condition in the script as I did not have the docker hub credentials setup.