Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add distance to NEARBY IDS response #657

Merged
merged 1 commit into from
Sep 17, 2022

Conversation

iwpnd
Copy link
Contributor

@iwpnd iwpnd commented Sep 17, 2022

resolves #656

@tidwall tidwall merged commit 4a0bab3 into tidwall:master Sep 17, 2022
@tidwall
Copy link
Owner

tidwall commented Sep 17, 2022

lgtm

@tidwall
Copy link
Owner

tidwall commented Sep 19, 2022

Also I like the way you are handling the test response, using a function that probes the json directly, as opposed to the RESP string response.

@iwpnd
Copy link
Contributor Author

iwpnd commented Sep 19, 2022

Thanks but that credit goes to u :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DISTANCE+IDS does not work for NEARBY. Distances are missing.
2 participants