Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

To properly support kubernetes & Sentinel. replica_announce properties should be supported #692

Closed
Kilowhisky opened this issue Jun 28, 2023 · 1 comment
Closed

To properly support kubernetes & Sentinel. replica_announce properties should be supported #692

Kilowhisky opened this issue Jun 28, 2023 · 1 comment

Comments

@Kilowhisky
Copy link
Contributor

Is your feature request related to a problem? Please describe.
replica_announce_ip and replica_announce_port are used by Redis followers to tell the leader and sentinels how to contact them. This is used by Redis helm chart in order to allow ingress from Kubernetes (at least in this helm chart) by external clients.

Describe the solution you'd like
They should be supported.

A PR is incoming :-)
Kilowhisky added a commit to Kilowhisky/tile38 that referenced this issue Jun 28, 2023
@Kilowhisky
To properly support kubernetes & Sentinel. replica_announce propertie…
f11aedb 
…s should be supported tidwall#692
@Kilowhisky Kilowhisky mentioned this issue Jun 28, 2023
Merged
@Kilowhisky
Copy link
Contributor Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Kilowhisky