Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure in internal/clip/clip_test.go #558

Closed
mmcloughlin opened this issue May 3, 2020 · 1 comment
Closed

Build failure in internal/clip/clip_test.go #558

mmcloughlin opened this issue May 3, 2020 · 1 comment

Comments

@mmcloughlin
Copy link

Describe the bug
Build failure in internal/clip/clip_test.go

To Reproduce

#!/bin/bash -ex

cd $(mktemp -d)
git clone https://github.com/tidwall/tile38.git
cd tile38
go test ./internal/clip

Expected behavior
Test pass.

Logs

++ mktemp -d
+ cd /tmp/tmp.AzpesgkwBc
+ git clone https://github.com/tidwall/tile38.git
Cloning into 'tile38'...
remote: Enumerating objects: 15996, done.
remote: Total 15996 (delta 0), reused 0 (delta 0), pack-reused 15996
Receiving objects: 100% (15996/15996), 41.47 MiB | 2.61 MiB/s, done.
Resolving deltas: 100% (6971/6971), done.
+ cd tile38
+ go test ./internal/clip
# github.com/tidwall/tile38/internal/clip [github.com/tidwall/tile38/internal/clip.test]
internal/clip/clip_test.go:91:17: not enough arguments in call to Clip
	have (*geojson.Polygon, *geojson.Rect)
	want (geojson.Object, geojson.Object, *geometry.IndexOptions)
FAIL	github.com/tidwall/tile38/internal/clip [build failed]
FAIL

Operating System (please complete the following information):

$ uname -a
Linux xps 5.0.0-1047-oem-osp1 #52-Ubuntu SMP Fri Mar 27 16:20:01 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
@mmcloughlin mmcloughlin changed the title Build failure in internal/clip/clip_test.go Build failure in internal/clip/clip_test.go May 3, 2020
tidwall added a commit that referenced this issue May 3, 2020
@tidwall
Copy link
Owner

tidwall commented May 3, 2020

Thanks for reporting this Michael. All fixed.

@tidwall tidwall closed this as completed May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants