feat(android): option to remove X-Titanium-Id in request header #14221
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the httpclient will always set a
X-Titanium-Id
. You can set it to be a different string or empty but you can't remove it.This PR will add a propety
titaniumId: false
so you can disable it. If it is not set it will still betrue
so it doesn't change anything for users that rely on it.output without the PR:
TODO:
Would be nice to have it here: https://github.com/tidev/titanium-sdk/blob/master/iphone/Classes/TiNetworkHTTPClientProxy.m#L53 for iOS too