revert(android): revert method signatures for compatibility

[prashantsaini1]

• This PR reverts the method removeOnLifecycleEventListener return type which was earlier void but changed to boolean in another PR here.
• It also reverts all other similar methods return type for consistency (though all other methods were newly added).

It allows modules, compiled with older SDKs (<= 12.6.4), to run on newer SDK versions with the another PR merged.

[m1ga]

LGTM.

Which module was causing issues here?

[prashantsaini1]

The latest Android code of ti.bottomsheet module which uses removeOnLifecycleEventListener.

• It will crash the app if we compile the module with <= 12.6.4.GA but build the app with the latest ti-sdk master (12.7.0) as the signatures will be different in this case.
• However, using the same SDK version to compile both the module and the apps will be fine.

[m1ga]

Ah ok. I was scanning through some Ti modules and didn't find it in there. Still strange because you are not using the return value so in my opinion it should call the same method. But glad this fixes it

[prashantsaini1]

Whether or not we use the return value, at compilation of the module the Java Class will be used based on the SDK version which will differ in return type for different SDK versions without this PR.

[m1ga]

I see, just tested it and can confirm:

No virtual method removeOnLifecycleEventListener(Lorg/appcelerator/titanium/TiLifecycle$OnLifecycleEvent;)V in class Lorg/appcelerator/titanium/TiBaseActivity; or its super classes (declaration of 'org.appcelerator.titanium.TiBaseActivity'

with this changes it works again.

Side note: you might want to update the Calling .toColor() without Context parameter is deprecated in your module.

[prashantsaini1]

Yes, that's the crash error. Thanks for the hint on toColor, just pushed it too.

However, I think that we should use current-activity context if available, otherwise the TiApplication context in the SDK itself to make it backward compatible and remove that deprecated warning. Reason being that majority of the use cases will rely on the current activity context. What do you think?

e.g.

Configuration config;

if (context != null) {
    config = context.getResources().getConfiguration();
} else if (TiApplication.getAppCurrentActivity() != null) {
    config = TiApplication.getAppCurrentActivity().getResources().getConfiguration();
} else {
    config = TiApplication.getInstance().getResources().getConfiguration();
}

[m1ga]

The deprecation note is a preparation of this PR #13273
But I don't have any more details about that PR. I just know it will break all modules that don't use the new toColor way. But I think most first party modules are update by now.

[prashantsaini1]

@m1ga Thanks. @hansemannn We can merge this PR now.