Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): hideShadow handling for iOS 13 #11240

Merged
merged 3 commits into from
Oct 2, 2019
Merged

fix(ios): hideShadow handling for iOS 13 #11240

merged 3 commits into from
Oct 2, 2019

Conversation

vijaysingh-axway
Copy link
Contributor

@build build added this to the 8.2.1 milestone Sep 24, 2019
@build build requested a review from a team September 24, 2019 21:54
@build
Copy link
Contributor

build commented Sep 24, 2019 •
edited
Loading

Messages
📖

✅ All tests are passing
Nice one! All 2097 tests are passing.
(There are 244 tests skipped)
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Generated by 🚫 dangerJS against a46a60f

@hansemannn
Copy link
Collaborator

There are some related issues to the navigation-bar like the titleTextAttributes and translucent property are not working correctly. It would be great if someone could take a look at this.

@vijaysingh-axway
Copy link
Contributor Author

There are some related issues to the navigation-bar like the titleTextAttributes and translucent property are not working correctly. It would be great if someone could take a look at this.

@hansemannn Can you give a reproducible test case to debug for your mentioned issue please? Thanks!

@ssekhri
Copy link

ssekhri commented Sep 27, 2019

FR Passed.
Verified On:
Mac OS: 10.14.5
SDK: 8.2.1.v20190924143534
Appc CLI: 7.1.1
JDK: 1.8.0_162
Node: 10.5.0
Studio: 5.1.4.201909061933
Xcode: 11.0
Device: iPhone X(13.0), iPhone 7Plus(12.3.1)

@sgtcoolguy sgtcoolguy merged commit c6a4ba7 into tidev:8_2_X Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janvennemann janvennemann janvennemann approved these changes

Assignees
No one assigned
Labels
bug in-qe-testing 🕵 ios no tests
Projects
None yet
Milestone
8.2.1
Development

Successfully merging this pull request may close these issues.
6 participants
@vijaysingh-axway @build @hansemannn @ssekhri @janvennemann @sgtcoolguy