feat(android): add fixedSize to RecyclerViews (#13138)

* feat(android): add fixedSize to ListView * feat(android): add fixedSize to TableView * docs * docs
tidev · Apr 12, 2022 · d057eed · d057eed
1 parent 0d20ec0
commit d057eed
Show file tree

Hide file tree

Showing 5 changed files with 27 additions and 0 deletions.
diff --git a/android/modules/ui/src/java/ti/modules/titanium/ui/widget/listview/TiListView.java b/android/modules/ui/src/java/ti/modules/titanium/ui/widget/listview/TiListView.java
@@ -267,6 +267,9 @@ public boolean inSelectionHotspot(@NonNull MotionEvent e)
 		final boolean allowsMultipleSelection
 			= properties.optBoolean(TiC.PROPERTY_ALLOWS_MULTIPLE_SELECTION_DURING_EDITING, false);
 
+		if (properties.optBoolean(TiC.PROPERTY_FIXED_SIZE, false)) {
+			this.recyclerView.setHasFixedSize(true);
+		}
 		if (editing && allowsSelection) {
 			if (allowsMultipleSelection) {
 				this.tracker = trackerBuilder.withSelectionPredicate(SelectionPredicates.createSelectAnything())

diff --git a/android/modules/ui/src/java/ti/modules/titanium/ui/widget/tableview/TiTableView.java b/android/modules/ui/src/java/ti/modules/titanium/ui/widget/tableview/TiTableView.java
@@ -244,6 +244,9 @@ public boolean inSelectionHotspot(@NonNull MotionEvent e)
 		final boolean allowsMultipleSelection
 			= properties.optBoolean(TiC.PROPERTY_ALLOWS_MULTIPLE_SELECTION_DURING_EDITING, false);
 
+		if (properties.optBoolean(TiC.PROPERTY_FIXED_SIZE, false)) {
+			this.recyclerView.setHasFixedSize(true);
+		}
 		if (editing && allowsSelection) {
 			if (allowsMultipleSelection) {
 				this.tracker = trackerBuilder.withSelectionPredicate(SelectionPredicates.createSelectAnything())

diff --git a/android/titanium/src/java/org/appcelerator/titanium/TiC.java b/android/titanium/src/java/org/appcelerator/titanium/TiC.java
@@ -832,6 +832,7 @@ public class TiC
 	public static final String PROPERTY_LASTPHONETIC = "lastPhonetic";
 	public static final String PROPERTY_JOBTITLE = "jobTitle";
 	public static final String PROPERTY_DEPARTMENT = "department";
+	public static final String PROPERTY_FIXED_SIZE = "fixedSize";
 
 	public static final String SIZE_AUTO = "auto";
 	public static final String URL_APP_PREFIX = "app://";

diff --git a/apidoc/Titanium/UI/ListView.yml b/apidoc/Titanium/UI/ListView.yml
@@ -685,6 +685,16 @@ properties:
     since: 7.5.0
     platforms: [android]
 
+  - name: fixedSize
+    summary: Sets fixedSize mode on Android ListViews.
+    description: |
+        Set it to `true` if all ListItems have the same size to gain some performance.
+    type: Boolean
+    default: false
+    availability: creation
+    since: 10.2.0
+    platforms: [android]
+
   - name: allowsSelectionDuringEditing
     summary: Determines whether this list view items can be selected while editing the table.
     type: Boolean

diff --git a/apidoc/Titanium/UI/TableView.yml b/apidoc/Titanium/UI/TableView.yml
@@ -1154,6 +1154,16 @@ properties:
     default: true
     platforms: [android, iphone, ipad, macos]
 
+  - name: fixedSize
+    summary: Sets fixedSize mode on Android TableView.
+    description: |
+        Set it to `true` if all TableView items have the same size to gain some performance.
+    type: Boolean
+    default: false
+    availability: creation
+    since: 10.2.0
+    platforms: [android]
+
   - name: footerDividersEnabled
     summary: When set to false, the ListView will not draw the divider before the footer view.
     type: Boolean