fix(ios): revert changes of TIMOB-27935 (#12152)

Fixes TIMOB-28148
tidev · Oct 2, 2020 · 23c01db · 23c01db
1 parent 3fcd69f
commit 23c01db
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 3 deletions.
diff --git a/iphone/Classes/TiUITableViewRowProxy.m b/iphone/Classes/TiUITableViewRowProxy.m
@@ -528,8 +528,7 @@ - (TiProxy *)parentForBubbling
 
 - (UIView *)view
 {
-  //TIMOB-27935: TiUITableViewRowProxy do not have corresponding view class. So return corresponding cell
-  return callbackCell;
+  return nil;
 }
 
 //Private method : For internal use only

diff --git a/tests/Resources/ti.ui.tableview.test.js b/tests/Resources/ti.ui.tableview.test.js
@@ -1387,7 +1387,8 @@ describe('Titanium.UI.TableView', function () {
 		win.open();
 	});
 
-	it.ios('row#rect', function (finish) {
+	it.iosBroken('row#rect', function (finish) {
+		// FIXME: TIMOB-27935
 		if (isCI && utilities.isMacOS()) { // FIXME: On macOS CI (maybe < 10.15.6?), times out! Does app need explicit focus added?
 			return finish(); // FIXME: skip when we move to official mocha package
 		}
@@ -1443,4 +1444,29 @@ describe('Titanium.UI.TableView', function () {
 		});
 		win.open();
 	});
+
+	it('TIMOB-28148 : adding view on row causing crash', function (finish) {
+		var row = Ti.UI.createTableViewRow({ title: 'click me' });
+		var tableView = Ti.UI.createTableView({
+			data: [ row ]
+		});
+
+		win = Ti.UI.createWindow({
+			backgroundColor: 'blue'
+		});
+		win.addEventListener('focus', function () {
+			setTimeout(function () {
+				try {
+					const label = Ti.UI.createLabel({ text: 'REQUIRED' });
+					row.add(label);
+					finish();
+				} catch (err) {
+					return finish(err);
+				}
+			}, 2000);
+		});
+
+		win.add(tableView);
+		win.open();
+	});
 });