You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Complete module rewrite using Swift. This will introduce breaking changes in terms of SDK compatibility as well as API changes. It's currently work in progress but i already want to use this PR to discuss the API changes.
I created new docs under https://github.com/janvennemann/ti.admob/tree/MOD-2495/docs which represent the current state of the iOS API with Swift. There is a doc for each proxy containing detailed API references and parity info at the bottom. The main changes that i would propose for this module would be:
Module
Changes
New method initialize to initialize the Google Ads SDK
New method createBannerView to create banner views. I think this one is currently called createView in Android.
New constants AD_SIZE_* to be able to specify different banner sizes.
Ad will now be loaded via load and options can be passed for each load request.
Ad size can be specified via the new AdSize proxy.
Renamed events to be more JS'ish BREAKING CHANGE
Parity notes
Android: loadAd and requestAd can be replaced by load
Android: All properties except for adUnitId and adSize can be removed. Ad request customization is done via load(options).
The only breaking change so far on Android would be the event renaming. However this can be avoided if we internally map the old event names to the new ones. The old methods can just be deprecated and the new ones introduced alongside them.
The build is currently failing because i had to remove the Google ad framework because it exceeds GitHubs files limit in the newest version. We have to come up with a different way to integrate it in CI builds. For local builds it can just be downloaded manually.
load supports options to customize the ad request.
adUnitId is a property without getter/setter
Event names are the same as for the banner view. The Android docs state that there is an additional AD_CLICKED event but i couldn't find that in the source.
@Astrovic, yes that's accounted for in the API changes. Every add will have a load(options) method that allows to pass extras among other add request customization.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete module rewrite using Swift. This will introduce breaking changes in terms of SDK compatibility as well as API changes. It's currently work in progress but i already want to use this PR to discuss the API changes.
I created new docs under https://github.com/janvennemann/ti.admob/tree/MOD-2495/docs which represent the current state of the iOS API with Swift. There is a doc for each proxy containing detailed API references and parity info at the bottom. The main changes that i would propose for this module would be:
Module
Changes
initialize
to initialize the Google Ads SDKcreateBannerView
to create banner views. I think this one is currently calledcreateView
in Android.Parity notes
Banner view proxy
Changes
load
and options can be passed for each load request.AdSize
proxy.Parity notes
loadAd
andrequestAd
can be replaced byload
adUnitId
andadSize
can be removed. Ad request customization is done viaload(options)
.The only breaking change so far on Android would be the event renaming. However this can be avoided if we internally map the old event names to the new ones. The old methods can just be deprecated and the new ones introduced alongside them.
cc @ypbnv