Skip to content

Commit

Permalink
Merge pull request #237 from tidev/improvement/help-text
Browse files Browse the repository at this point in the history
  • Loading branch information
cb1kenobi authored Sep 28, 2023
2 parents 18d821d + 007aa68 commit f14ed2c
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
6 changes: 4 additions & 2 deletions lib/simulator.js
Original file line number Diff line number Diff line change
Expand Up @@ -771,11 +771,13 @@ function findSimulators(options, callback) {
}

if (!simHandle) {
const helpText = '\n\nPlease open Xcode, navigate to "Window > Devices and Simulators" and create a new Simulator with your preferred configuration.';

// user experience!
if (options.simVersion) {
return callback(new Error(__('Unable to find an iOS Simulator running iOS %s.', options.simVersion)));
return callback(new Error(__(`Unable to find an iOS Simulator running iOS %s. ${helpText}`, options.simVersion)));
} else {
return callback(new Error(__('Unable to find an iOS Simulator.')));
return callback(new Error(__(`Unable to find an iOS Simulator. ${helpText}`)));
}
} else if (options.watchAppBeingInstalled && !watchSimHandle) {
return callback(new Error(__('Unable to find a watchOS Simulator that supports watchOS %s', options.watchMinOSVersion)));
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ioslib",
"version": "1.7.34",
"version": "1.7.35",
"description": "iOS Utility Library",
"keywords": [
"appcelerator",
Expand Down

0 comments on commit f14ed2c

Please sign in to comment.