Skip to content

make carthage bootstrap step verbose#8

Merged
rickpasetto merged 3 commits intodevfrom
rick/carthage-bootstrap-verbose
Jun 1, 2020
Merged

make carthage bootstrap step verbose#8
rickpasetto merged 3 commits intodevfrom
rick/carthage-bootstrap-verbose

Conversation

@rickpasetto
Copy link
Contributor

In order to avoid Travis build failures (due to its 10 minute 'no output' timeout), this ensures that the carthage bootstrap step outputs something while it is working.

@rickpasetto rickpasetto requested a review from darinkrauss May 29, 2020 22:45
Copy link
Contributor

@darinkrauss darinkrauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this also includes some changes to enable caching, yes? If so, please include this in the final merge commit notes (as it is probably more important that the verbose logs).

Hopefully we can remove these verbose logs once we get the build straightened out.

@rickpasetto
Copy link
Contributor Author

My apologies, @darinkrauss . You are right -- these two things should have been separate PRs. The --verbose PR was solely an attempt to fix Travis builds (which were timing out). The "bootstrap-if-needed" strategy was not related; it was part of my work to cache builds (specifically for CircleCI). I accidentally put the latter change into this branch. Will fix it.

@rickpasetto rickpasetto merged commit 3bf1656 into dev Jun 1, 2020
@rickpasetto rickpasetto deleted the rick/carthage-bootstrap-verbose branch June 1, 2020 22:19
ps2 added a commit that referenced this pull request Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants