LOOP-873 Upload Loop glucose and carbohydrate data to Tidepool backend#7
Merged
darinkrauss merged 2 commits intodevfrom Apr 24, 2020
Merged
Conversation
Contributor
darinkrauss
commented
Apr 23, 2020
darinkrauss
commented
- https://tidepool.atlassian.net/browse/LOOP-873
- Upload carbohydrate and glucose data to Tidepool backend
- Delete carbohydrate data from Tidepool backend
- Add DeletedCarbEntry extension to generate TSelector
- Add StoredCarbEntry extension to generate TDatum
- Add StoredGlucose extension to generate TDatum
- Add default origin for main bundle
- https://tidepool.atlassian.net/browse/LOOP-873 - Upload carbohydrate and glucose data to Tidepool backend - Delete carbohydrate data from Tidepool backend - Add DeletedCarbEntry extension to generate TSelector - Add StoredCarbEntry extension to generate TDatum - Add StoredGlucose extension to generate TDatum - Add default origin for main bundle
Contributor
Author
|
See https://github.com/tidepool-org/LoopWorkspace/pull/72 for LoopWorkspace build confirmation. |
rickpasetto
approved these changes
Apr 24, 2020
Contributor
rickpasetto
left a comment
rickpasetto
left a comment
There was a problem hiding this comment.
Minor suggestion, but other than that LGTM 🧀
|
|
||
| extension TDatum: CustomDebugStringConvertible { | ||
| public var debugDescription: String { | ||
| let encoder = JSONEncoder() |
Contributor
There was a problem hiding this comment.
[nit] Super-minor nit, but way back in my memory I seem to remember that creating JSONEncoders can be a bit expensive. Possibly consider making it a fileprivate global reusable constant here? (Or, if you know of other places it may be reused, put it in a better, reusable place, if you want). Again, not a blocker.
darinkrauss
deleted the
darinkrauss/LOOP-873-upload-glucose-carbohydrate-data
branch
ps2
added a commit
that referenced
this pull request
Apr 21, 2023
Updated translations from Lokalise on Sat Mar 18 15:11:44 CDT 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.