LOOP-5122 Use continue button during onboarding#110
Merged
Conversation
Camji55
approved these changes
Oct 25, 2024
| Button(action: { | ||
| dismiss?() | ||
| }) { | ||
| Text(LocalizedString("Continue", comment: "Delete Tidepool service button title")) |
Member
There was a problem hiding this comment.
FYI, you don't need to use a LocalizedString inside a Text initializer. You can do this instead to the same effect:
Suggested change
| Text(LocalizedString("Continue", comment: "Delete Tidepool service button title")) | |
| Text("Continue", comment: "Delete Tidepool service button title") |
Contributor
Author
There was a problem hiding this comment.
We use LocalizedString in frameworks of Loop, so that the lookup happens from the framework's bundle instead of Loop's. You'll see this isn't NSLocalizedString, but a function local to the framework.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://tidepool.atlassian.net/browse/LOOP-5122
Additional mode when onboarding to show continue button instead of delete service button.