Merged
Conversation
Camji55
approved these changes
Sep 20, 2024
darinkrauss
requested changes
Sep 20, 2024
Comment on lines
192
to
193
| let origin = datumOrigin(for: resolvedIdentifier(for: TStatusDeviceEventDatum.self), hostIdentifier: hostIdentifier, hostVersion: hostVersion) | ||
| datum = datum.adornWith(id: datumId(for: userId, type: TStatusDeviceEventDatum.self), |
Contributor
There was a problem hiding this comment.
The TStatusDeviceEventDatum needs to be replaced with TTimeChangeDeviceEventDatum, I believe.
ps2
approved these changes
Sep 21, 2024
Contributor
ps2
left a comment
ps2
left a comment
There was a problem hiding this comment.
LGTM! Once Darin's request is completed.
nhamming
deleted the
nate/feature/LOOP-5035/pump-event-time-zone-sync
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://tidepool.atlassian.net/browse/LOOP-5035