Skip to content

LOOP-3964: Fix more pickers not using the wheel picker style #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rickpasetto merged 1 commit into from
Dec 10, 2021
Merged

LOOP-3964: Fix more pickers not using the wheel picker style #428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions LoopKitUI/Views/CardList/TimePicker.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ public struct TimePicker: View {
self.text(for: time)
}
}
.pickerStyle(.wheel)
.labelsHidden()
}

Expand Down
2 changes: 1 addition & 1 deletion LoopKitUI/Views/ExpandablePicker.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public struct ExpandablePicker: View {
Text(self.items[$0])
}
}
.pickerStyle(WheelPickerStyle())
.pickerStyle(.wheel)
.labelsHidden()
}
}
Expand Down
2 changes: 1 addition & 1 deletion LoopKitUI/Views/QuantityPicker.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ public struct QuantityPicker: View {
public var body: some View {
picker
.labelsHidden()
.pickerStyle(WheelPickerStyle())
.pickerStyle(.wheel)
.overlayPreferenceValue(PickerValueBoundsKey.self, unitLabel(positionedFrom:))
.accessibility(identifier: "quantity_picker")
}
Expand Down