Some FileManager extensions #236
Conversation
rickpasetto
changed the title
| @@ -161,8 +159,7 @@ public final class PersistenceController { | |||
| options: [ | |||
| NSMigratePersistentStoresAutomaticallyOption: true, | |||
| NSInferMappingModelAutomaticallyOption: true, | |||
| // Data should be available on reboot before first unlock | |||
| NSPersistentStoreFileProtectionKey: FileProtectionType.none | |||
| NSPersistentStoreFileProtectionKey: FileProtectionType.completeUntilFirstUserAuthentication | |||
There was a problem hiding this comment.
This also changes the default data protection of the .sqlite file. After perusing the documentation, I'm not sure what CoreData does if you change the NSPersistentStoreFileProtectionKey. One hopes it does something like the extension above does.
There was a problem hiding this comment.
Yeah, I'm not sure. If we really wanted to migrate the protection levels of existing files, I'm guessing we'd have to do more than just this.
There was a problem hiding this comment.
@ps2 Maybe. This SO post (admittedly it's weak evidence) seems to indicate that CoreData handles this:
Would you like me to double-check before merging this? It'd be easiest to just forge a new app and test it.
There was a problem hiding this comment.
@ps2 I have written a sample app to test the theory about whether CoreData automatically updates the file protection mode, and I have convinced myself it does. If you want details, I'd be happy to share them.
| @@ -161,8 +159,7 @@ public final class PersistenceController { | |||
| options: [ | |||
| NSMigratePersistentStoresAutomaticallyOption: true, | |||
| NSInferMappingModelAutomaticallyOption: true, | |||
| // Data should be available on reboot before first unlock | |||
| NSPersistentStoreFileProtectionKey: FileProtectionType.none | |||
| NSPersistentStoreFileProtectionKey: FileProtectionType.completeUntilFirstUserAuthentication | |||
There was a problem hiding this comment.
Yeah, I'm not sure. If we really wanted to migrate the protection levels of existing files, I'm guessing we'd have to do more than just this.
# Conflicts: # LoopKit/Persistence/PersistenceController.swift
In response to some feedback from tidepool-org/Loop#247, I've consolidated some of the handier functions in a
FileManagerextension for use elsewhere.(Note: this actually fixes a minor bug in
PersistenceController:fileExiststakes a path not a URL string)