Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App hassgraph: fix case of unknown values #2895

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ChaosKid42
Copy link
Contributor

App HASS Graph:

This PR makes the App skip unknown values from HA.

@vincentezw : Hope you approve.

@ChaosKid42 ChaosKid42 requested a review from matslina as a code owner December 7, 2024 09:17
@tidbyt
Copy link

tidbyt bot commented Dec 7, 2024

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of animation.star requires review
🟡 Original Author The original author (vincentezw) does not match the PR author (ChaosKid42)

@matslina
Copy link
Contributor

matslina commented Dec 7, 2024

@vincentezw Assuming this is cool to merge? Seems uncontroversial.

@vincentezw
Copy link
Contributor

LGTM

@ChaosKid42 ChaosKid42 force-pushed the hassgraph_fix_unknown_values branch from 750f260 to 0603ddd Compare December 21, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants