Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add serverless cluster #160

Open
wants to merge 36 commits into
base: main
Choose a base branch
from
Open

Add serverless cluster #160

wants to merge 36 commits into from

Conversation

FingerLeader
Copy link
Contributor

What problem does this PR solve?

What is changed and how it works?

Check List

  • Possible to add a test?
  • Don't forget to run go generate if you modify examples.

@FingerLeader
add setup-terraform
284eb38 
Signed-off-by: FingerLeader <wanxfinger@gmail.com>
@FingerLeader
Merge branch 'main' of github.com:tidbcloud/terraform-provider-tidbcloud
2bdf1bc
@FingerLeader
add serverless cluster
59cfc23 
Signed-off-by: FingerLeader <wanxfinger@gmail.com>
shiyuhang0
shiyuhang0 reviewed Feb 21, 2025
View reviewed changes
@shiyuhang0
Copy link
Collaborator

We need to provide a way to create a serverless cluster in a specific project.
it can be specified via label in open api

@FingerLeader
resolve comments
9beef75 
Signed-off-by: FingerLeader <wanxfinger@gmail.com>
@FingerLeader
resolve comments
91be960 
Signed-off-by: FingerLeader <wanxfinger@gmail.com>
@shiyuhang0 shiyuhang0 force-pushed the add-serverless-cluster branch from fbe5056 to b7c4957 Compare February 28, 2025 02:51
@shiyuhang0 shiyuhang0 force-pushed the add-serverless-cluster branch from 19de604 to dcc2ff0 Compare February 28, 2025 03:21
@shiyuhang0
Copy link
Collaborator

better to add update test for the serverless cluster resource

@shiyuhang0 shiyuhang0 force-pushed the add-serverless-cluster branch from e6ada82 to 184607b Compare February 28, 2025 03:50
FingerLeader and others added 7 commits February 28, 2025 18:01
@FingerLeader
resolve comments
6e792c5 
Signed-off-by: FingerLeader <wanxfinger@gmail.com>
@shiyuhang0
fix test
abb23e4
@FingerLeader
resolve comments
fb72543 
Signed-off-by: FingerLeader <wanxfinger@gmail.com>
@FingerLeader
Merge branch 'add-serverless-cluster' of github.com:tidbcloud/terrafo…
af45c32 
…rm-provider-tidbcloud into add-serverless-cluster
@FingerLeader
resolve comments
3327e39 
Signed-off-by: FingerLeader <wanxfinger@gmail.com>
@FingerLeader
tmp save
782251b 
Signed-off-by: FingerLeader <wanxfinger@gmail.com>
@FingerLeader
resolve comments
d327d32 
Signed-off-by: FingerLeader <wanxfinger@gmail.com>
@FingerLeader
fix test
55af286 
Signed-off-by: FingerLeader <wanxfinger@gmail.com>
@FingerLeader
generate
4a06ca9 
Signed-off-by: FingerLeader <wanxfinger@gmail.com>
@FingerLeader
remove high availability type
433eb1d 
Signed-off-by: FingerLeader <wanxfinger@gmail.com>
@shiyuhang0
Copy link
Collaborator

shiyuhang0 commented Mar 4, 2025 •
edited
Loading

Tests:

  1. when creating without the project field (created in the default project), then add the default project ID. It trigger replacement, it is not right.
  2. No updatable field found occurs when execute terrraform apply without any change
  3. The spending limit can be negative. I think it is the problem of open api
  4. The wrong start_time format also works. for example, 12. I think it is the problem of open API
  5. The host and port will show known after apply when the endpoints field is specified in configurations. Please reduce the known after apply as much as you can.
    image
  6. change region does not trigger replacement
    image

FingerLeader and others added 8 commits March 4, 2025 16:04
@FingerLeader
resolve comments
3002692 
Signed-off-by: FingerLeader <wanxfinger@gmail.com>
@shiyuhang0
Update internal/provider/serverless_cluster_resource.go
6347ea7
@FingerLeader
resolve comments
4d0e52a 
Signed-off-by: FingerLeader <wanxfinger@gmail.com>
@FingerLeader @shiyuhang0
Update internal/provider/serverless_cluster_resource.go
b5e1ad0 
Co-authored-by: shi yuhang <52435083+shiyuhang0@users.noreply.github.com>
@FingerLeader
Merge branch 'add-serverless-cluster' of github.com:tidbcloud/terrafo…
29cd7b3 
…rm-provider-tidbcloud into add-serverless-cluster
@FingerLeader
resolve comments
f9cac0a 
Signed-off-by: FingerLeader <wanxfinger@gmail.com>
@FingerLeader
fix test
c611502 
Signed-off-by: FingerLeader <wanxfinger@gmail.com>
@shiyuhang0
Merge branch 'main' into add-serverless-cluster
0e48107
shiyuhang0
shiyuhang0 previously approved these changes Mar 4, 2025
View reviewed changes
@FingerLeader
fix
6effd0e 
Signed-off-by: FingerLeader <wanxfinger@gmail.com>
@FingerLeader
Merge branch 'add-serverless-cluster' of github.com:tidbcloud/terrafo…
bec5108 
…rm-provider-tidbcloud into add-serverless-cluster
@FingerLeader
update test
4ced76c 
Signed-off-by: FingerLeader <wanxfinger@gmail.com>
@FingerLeader FingerLeader force-pushed the add-serverless-cluster branch from 1c64e36 to 4ced76c Compare March 14, 2025 09:55
@FingerLeader
fix replace bug
41bfb16 
Signed-off-by: FingerLeader <wanxfinger@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiyuhang0 shiyuhang0 shiyuhang0 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FingerLeader @shiyuhang0