-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement echo=None functionality via run-as-program #21
Conversation
I'm not currently aware of any valid Stata code this can't handle. In particular,
|
Just to follow up on this, do you have an estimate on when you might have time to review this pull request? I'm looking to roll this out to others in my organization, and I'm wondering whether I should have them install from my own fork or wait to do it more cleanly via |
For anyone who sees this, I have now created a separate project which implements this pull request (after reorganizing the code) and makes other improvements: https://github.com/hugetim/nbstata |
My apology for being absent for so long. Sickness and work have kept me from coming online. I have merged your request. I am also thinking of how to make this project sustainable so that one person's sickness will not bring updates to a halt. I could perhaps add you as a collaborator? |
Thanks! I would like to collaborate but I'm not sure the best way to go about it. I think I've made a number of improvements to my version in the past week or so. But they would be hard to port over to |
Maybe we should arrange a video call to talk about this?
…On Mon, Nov 28, 2022, 3:32 PM Vinci Chow ***@***.***> wrote:
Merged #21 <#21> into main.
—
Reply to this email directly, view it on GitHub
<#21 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB63GLG642B2VQ5RIMA43CTWKUQFRANCNFSM6AAAAAARDQKB2Q>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
To be more specific about the fixes and features I've added in
I've been super-fortunate to have some free time at my job recently during which I've been able to work on this stuff on the clock. But that is unlikely to last for long. |
Addresses #16, supersedes #15 and #18.