Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable marker overlay by default #46

Open
mathiasbynens opened this issue May 22, 2022 · 1 comment
Open

Disable marker overlay by default #46

mathiasbynens opened this issue May 22, 2022 · 1 comment

Comments

@mathiasbynens
Copy link
Member

On pages like https://tibiamaps.io/blog/summer-update-2021 the performance impact of loading all markers by default is very obvious. Just like the exiva layer, we should disable it by default.
@mathiasbynens
Copy link
Member Author

Ideally we could configure this via another data-* attribute e.g. data-show-markers="true".

@tiagomartines11, is this something you wanna take on? :)

tiagomartines11 added a commit to tiagomartines11/tibia-map that referenced this issue May 22, 2022
@tiagomartines11
Allow enabling of markers via attributes (default: false)
96b43ba 
Issue: tibiamaps#46
@tiagomartines11 tiagomartines11 mentioned this issue May 22, 2022
Merged
mathiasbynens pushed a commit that referenced this issue May 22, 2022
@tiagomartines11
Allow enabling of markers via attributes (default: false) (#47)
f2b3194 
Issue: #46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mathiasbynens