Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marker overlay: add ability to select marker pack #43

Open
mathiasbynens opened this issue May 21, 2022 · 2 comments
Open

Marker overlay: add ability to select marker pack #43

mathiasbynens opened this issue May 21, 2022 · 2 comments
Assignees
@mathiasbynens

Comments

@mathiasbynens
Copy link
Member

Currently the marker overlay shows the default marker pack. It would be nice to select other packs (but not necessarily all of them). The most important other pack right now would be the PoI pack — it would be super useful to visualize which PoI areas we’ve already marked without having to actually install the pack locally. cc @tiagomartines11
@mathiasbynens mathiasbynens changed the title Add ability to select marker pack Marker overlay: add ability to select marker pack May 21, 2022
@mathiasbynens
Copy link
Member Author

mathiasbynens commented May 21, 2022 •
edited
Loading

I’m thinking of letting the embedder handle this via a data-marker-pack="minimap-with-grid-overlay-and-poi-markers/markers.json" attribute on the <div id="map"> element.

@mathiasbynens mathiasbynens self-assigned this May 21, 2022
mathiasbynens added a commit that referenced this issue May 21, 2022
@mathiasbynens
Allow embedders to control the marker pack via data-marker-pack="…"
f910476 
Issue: #43
@mathiasbynens
Copy link
Member Author

The PoI pack can now be viewed at https://tibiamaps.io/map/poi.

@tiagomartines11 tiagomartines11 mentioned this issue May 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mathiasbynens mathiasbynens

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mathiasbynens