Add unit tests for News List API and News API #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #60 +/- ##
===========================================
+ Coverage 47.54% 62.43% +14.88%
===========================================
Files 17 17
Lines 2467 2364 -103
===========================================
+ Hits 1173 1476 +303
+ Misses 1249 831 -418
- Partials 45 57 +12 |
Member
tobiasehlert
left a comment
tobiasehlert
left a comment
There was a problem hiding this comment.
Good base, but we'd need and other test scenario for the News part.
We should cover one ticker (which has I link inside itself) (e.g. 6512) and one news, since the response is different in both cases.
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
Author
|
Added 2 additional unit tests to cover another ticker based article and a news article. |
tobiasehlert
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.