fix(ci): use dockerhub variable instead #509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasehlert
added
the
github_actions
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates GitHub Actions workflows to use GitHub Variables instead of Secrets for the DockerHub username, aligning with best practices where usernames are not sensitive information.
- Changes DockerHub username references from
secrets.DOCKERHUB_USERNAMEtovars.DOCKERHUB_USERNAME - Updates both build and DockerHub description workflows consistently
- Maintains security by keeping the DockerHub token as a secret
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/dockerhub.yml | Updates DockerHub username reference in description workflow |
| .github/workflows/build.yml | Updates DockerHub username references in build workflow login steps |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor update to the GitHub Actions workflow by changing how the DockerHub username is referenced. The workflow now uses GitHub Actions variables instead of secrets for the DockerHub username in all relevant steps.
rel #508