Skip to content

Handle timezone information during DateTime parsing (#46) #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 10, 2022
Merged

Handle timezone information during DateTime parsing (#46) #49

merged 8 commits into from
Jan 10, 2022

Conversation

@tobiasehlert
Copy link
Member

@tobiasehlert tobiasehlert commented Jan 9, 2022 •
edited
Loading

  • Handle timezone information during DateTime parsing
  • adjusting asserts to be UTC
  • updating TibiadataDatetimeV3 with correct format

Fixes #42

@kamilon @tobiasehlert
Handle timezone information during DateTime parsing (#46)
3fbda66 
* Handle timezone information during DateTime parsing

* adjusting asserts to be UTC

* updating TibiadataDatetimeV3 with correct format

Co-authored-by: Tobias Lindberg <tobias.ehlert@gmail.com>
@tobiasehlert tobiasehlert added the go Pull requests that update Go code label Jan 9, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2022 •
edited by codecov bot
Loading

Codecov Report

Merging #49 (17e98e3) into main (afdf2d5) will increase coverage by 0.19%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
+ Coverage   13.25%   13.45%   +0.19%     
==========================================
  Files          13       14       +1     
  Lines        1803     1799       -4     
==========================================
+ Hits          239      242       +3     
+ Misses       1556     1549       -7     
  Partials        8        8
Impacted Files Coverage Δ
src/webserver.go 10.08% <ø> (-3.03%) ⬇️
src/TibiaDataUtils.go 86.66% <86.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afdf2d5...17e98e3. Read the comment docs.

kamilon
kamilon reviewed Jan 10, 2022
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tobiasehlert tobiasehlert merged commit b080c52 into main Jan 10, 2022
@tobiasehlert tobiasehlert deleted the bug-42 branch January 10, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kamilon kamilon kamilon left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

go Pull requests that update Go code

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix TibiadataDatetimeV3 UTC timezone problem

4 participants

@tobiasehlert @codecov-commenter @kamilon