Skip to content

feat: support new vocation monk #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 3, 2025
Merged

feat: support new vocation monk #451

merged 2 commits into from
Apr 3, 2025

Conversation

@tobiasehlert
Copy link
Member

@tobiasehlert tobiasehlert commented Feb 26, 2025 •
edited
Loading

  • tests added in e57c0fa shall be updated with new data from tibia.com after merge

fix #449

@tobiasehlert tobiasehlert added documentation Improvements or additions to documentation enhancement New feature or request go Pull requests that update Go code labels Feb 26, 2025
@tobiasehlert tobiasehlert self-assigned this Feb 26, 2025
@codecov
Copy link

codecov bot commented Feb 26, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.81%. Comparing base (c961dd5) to head (e57c0fa).
Report is 12 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #451      +/-   ##
==========================================
+ Coverage   79.80%   79.81%   +0.01%     
==========================================
  Files          22       22              
  Lines        3654     3657       +3     
==========================================
+ Hits         2916     2919       +3     
  Misses        600      600              
  Partials      138      138
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 26, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@tobiasehlert tobiasehlert added the postponed Pull requests that are postponed for future implementation. label Feb 26, 2025
@tobiasehlert tobiasehlert merged commit 57742e6 into main Apr 3, 2025
8 checks passed
@tobiasehlert tobiasehlert deleted the feat-support-new-vocation-monk branch April 3, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@tobiasehlert tobiasehlert

Labels

documentation Improvements or additions to documentation enhancement New feature or request go Pull requests that update Go code postponed Pull requests that are postponed for future implementation.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: support new vocation monk

2 participants

@tobiasehlert