Skip to content

Fix not parsing all news ticker properly #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 10, 2023
Merged

Fix not parsing all news ticker properly #291

merged 2 commits into from
Nov 10, 2023

Conversation

@phenpessoa
Copy link
Contributor

@phenpessoa phenpessoa commented Nov 9, 2023

Fixes #290

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@phenpessoa phenpessoa changed the title Fix 290 Fix not parsing all news ticker properly Nov 9, 2023
@tobiasehlert tobiasehlert added the go Pull requests that update Go code label Nov 10, 2023
tobiasehlert
tobiasehlert approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@tobiasehlert tobiasehlert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobiasehlert tobiasehlert merged commit 62c5007 into tibiadata:main Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasehlert tobiasehlert tobiasehlert approved these changes

Assignees

No one assigned

Labels

go Pull requests that update Go code

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Various /news/id/* responses have empty content and content_html

2 participants

@phenpessoa @tobiasehlert