Skip to content

Conversation

@tobiasehlert
Copy link
Member

Older characters can have a longer length than 14.

Example char:

  • Crocodilo'Dundee

fix #193

older characters can have a longer length

fix #193
@tobiasehlert tobiasehlert added the go Pull requests that update Go code label Feb 19, 2023
@tobiasehlert tobiasehlert self-assigned this Feb 19, 2023
@codecov
Copy link

codecov bot commented Feb 19, 2023

Codecov Report

Merging #194 (7630f86) into main (5a7fdbf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #194   +/-   ##
=======================================
  Coverage   78.19%   78.19%           
=======================================
  Files          22       22           
  Lines        3472     3472           
=======================================
  Hits         2715     2715           
  Misses        622      622           
  Partials      135      135           

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

@ivansantos-dev ivansantos-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobiasehlert tobiasehlert merged commit 4542b23 into main Feb 19, 2023
@tobiasehlert tobiasehlert deleted the 193-extending-character-max-length branch February 19, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Pull requests that update Go code

Development

Successfully merging this pull request may close these issues.

/v4/character/{name} fails for certain names

3 participants