Skip to content

Conversation

@tiagomartines11
Copy link
Contributor

This fixes " (traded)" string appearing in account characters info.

An example of this bad behavior can be currently observed for this character https://api.tibiadata.com/v3/character/Trafnar

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@tobiasehlert tobiasehlert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, thanks!

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #133 (646478b) into main (e742759) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #133   +/-   ##
=======================================
  Coverage   80.59%   80.59%           
=======================================
  Files          21       21           
  Lines        2669     2669           
=======================================
  Hits         2151     2151           
  Misses        451      451           
  Partials       67       67           

@tobiasehlert tobiasehlert merged commit d9ced43 into tibiadata:main May 12, 2022
@tobiasehlert tobiasehlert added bug Something isn't working good first issue Good for newcomers go Pull requests that update Go code labels May 12, 2022
@tiagomartines11 tiagomartines11 deleted the fix-traded-string branch May 12, 2022 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working go Pull requests that update Go code good first issue Good for newcomers

Development

Successfully merging this pull request may close these issues.

2 participants