Skip to content

trimming suffix on guild rank #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2022
Merged

trimming suffix on guild rank #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/TibiaCharactersCharacterV3.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ func TibiaCharactersCharacterV3Impl(BoxContentHTML string) CharacterResponse {
HouseID: TibiaDataStringToIntegerV3(HouseId),
})
case "Guild Membership:":
CharacterInformationData.Guild.Rank = RowData
CharacterInformationData.Guild.Rank = strings.TrimSuffix(RowData, " of the ")

//TODO: I don't understand why the unicode nbsp is there...
CharacterInformationData.Guild.GuildName = TibiaDataSanitizeStrings(RowNameQuery.Nodes[0].NextSibling.LastChild.LastChild.Data)
Expand Down
4 changes: 2 additions & 2 deletions src/TibiaCharactersCharacterV3_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ func TestNumber1(t *testing.T) {
assert.Empty(characterJson.Characters.Character.MarriedTo)
assert.Nil(characterJson.Characters.Character.Houses)
assert.Equal("Jokerz", characterJson.Characters.Character.Guild.GuildName)
assert.Equal("Trial of the ", characterJson.Characters.Character.Guild.Rank)
assert.Equal("Trial", characterJson.Characters.Character.Guild.Rank)
assert.Equal("2022-01-05T21:23:32Z", characterJson.Characters.Character.LastLogin)
assert.Equal("Premium Account", characterJson.Characters.Character.AccountStatus)
assert.Empty(characterJson.Characters.Character.Comment)
Expand Down Expand Up @@ -67,7 +67,7 @@ func TestNumber2(t *testing.T) {
assert.Equal("Loot Lane 1 (Shop)", characterJson.Characters.Character.Houses[0].Name)
assert.Equal("Venore", characterJson.Characters.Character.Houses[0].Town)
assert.Equal("2022-01-16", characterJson.Characters.Character.Houses[0].Paid)
assert.Equal("Magnus Magister of the ", characterJson.Characters.Character.Guild.Rank)
assert.Equal("Magnus Magister", characterJson.Characters.Character.Guild.Rank)
assert.Equal("Lionheart Society", characterJson.Characters.Character.Guild.GuildName)
assert.Equal("2022-01-06T21:38:44Z", characterJson.Characters.Character.LastLogin)
assert.Equal("Testa de Ferro do Lejonhjartat ;)", characterJson.Characters.Character.Comment)
Expand Down