Closed
Conversation
Fix various typos in ArmPlatformPkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Coeur <coeur@gmx.fr>
Member
|
Please see my comment at: |
kuqin12
pushed a commit
to kuqin12/edk2
that referenced
this pull request
Nov 29, 2022
## Description To reduce the number of calls to SetMemoryAttributes(), merge contiguous memory map entries by only attribute instead of by attribute and type. ## Breaking change? No ## How This Was Tested Inspecting the merge and booting with added protections ## Integration Instructions N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Meta
This is an experimental pull request, as discussed many times on the edk2 mailing-list.
It is:
It fits the experiment of using a GitHub pull request over a mailing-list patch.
Once reviewed and approved, the maintainer of this repo (edk2) has multiple possibilities to handle it:
git pull https://github.com/coeur/edk2.git Typo-ArmPlatformPkg)Pull Request
This is actually a cherry pick for ArmPlatformPkg only from a larger change updated since 2018 at Coeur@1ee272d.