fix(cli): harden ACP/Codex event handling#211
Merged
tiann merged 1 commit intotiann:mainfrom Feb 25, 2026
Merged
Conversation
There was a problem hiding this comment.
Findings
- No issues found.
Questions
- For the consecutive-delta dedupe in
cli/src/codex/utils/appServerEventConverter.ts:321, do we have an upstream guarantee that identical consecutive deltas are duplicates (not legitimate repeated tokens/output)? If not, should we gate dedupe on a sequence/offset field instead of content equality?
Summary
- No issues found in the diff.
Testing
- Not run (automation)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What / Why
Make CLI event handling more robust across ACP/Codex streams (missing turn ids, out-of-order tool events, inconsistent payload shapes) and prevent duplicated “reasoning” text caused by repeated delta notifications.
Changes
turn_id).Tests
cd cli && bun run testcd cli && bun run typecheck