fix(web): add Shift+Enter to send messages on iPadOS#209
Merged
tiann merged 1 commit intotiann:mainfrom Feb 25, 2026
Merged
Conversation
On iPadOS with a hardware keyboard, `isTouch` is true (via pointer:coarse) so submitOnEnter is disabled and there's no keyboard-based way to send. Add Shift+Enter as a send shortcut that works on all platforms without changing existing behavior — desktop Enter-to-send is preserved. Closes tiann#175 via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Findings\n- None.\n\nSummary\n- No issues found in the diff. Residual risk: platform-specific key handling (iPadOS hardware keyboard, IME composition) relies on manual verification.\n\nTesting\n- Not run (automation). Suggested: desktop Enter/Shift+Enter, autocomplete open, iPadOS hardware keyboard, IME composition, empty input.\n\nHAPI Bot
kvinwang
added a commit
to kvinwang/hapi
that referenced
this pull request
Feb 27, 2026
Remove the Shift+Enter send handler added in tiann#209, which intercepted Shift+Enter on all platforms and prevented desktop users from inserting newlines. Desktop keeps Enter=send/Shift+Enter=newline; touch keeps Enter=newline with send button.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
devbranch; this applies the correct approach tomainWhat changed
In
HappyComposer.tsx:Shift+Enterkeydown handler that callsapi.composer().send()whencanSendis truecanSendandapito theuseCallbackdependency arrayWhy PR #178 didn't work
devbranch which is stuck at v0.7.3 — never reachedmain(v0.15.2)submitOnEntertofalseeverywhere, breaking desktop Enter-to-send behaviorBehavior after this fix
Test plan
Closes #175
🤖 Generated with Claude Code